[Bug 1177926] Review Request: smuxi - Powerful, flexible, user-friendly chat client

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1177926



--- Comment #6 from MartinKG <mgansser@xxxxxxxx> ---
a quick review.
1. rpmlint smuxi-0.11-1.fc21.src.rpm

smuxi.src: W: spelling-error %description -l en_US irssi -> IRS, RSI, sir
smuxi.src:73: E: hardcoded-library-path in %{_prefix}/lib
smuxi.src:110: E: hardcoded-library-path in %{_prefix}/lib/%{name}
smuxi.src:111: E: hardcoded-library-path in
%{_prefix}/lib/%{name}/%{name}-frontend-gnome.exe*
smuxi.src:112: E: hardcoded-library-path in
%{_prefix}/lib/%{name}/%{name}-frontend.dll*
smuxi.src:113: E: hardcoded-library-path in
%{_prefix}/lib/%{name}/%{name}-frontend-gnome-irc.dll*
smuxi.src:114: E: hardcoded-library-path in
%{_prefix}/lib/%{name}/%{name}-frontend-gnome-twitter.dll*
smuxi.src:115: E: hardcoded-library-path in
%{_prefix}/lib/%{name}/%{name}-frontend-gnome-xmpp.dll*
smuxi.src:116: E: hardcoded-library-path in
%{_prefix}/lib/%{name}/%{name}-server.exe*
smuxi.src:127: E: hardcoded-library-path in
%{_prefix}/lib/%{name}/Db4objects.Db4o.dll*
smuxi.src:128: E: hardcoded-library-path in
%{_prefix}/lib/%{name}/%{name}-engine.dll*
smuxi.src:129: E: hardcoded-library-path in
%{_prefix}/lib/%{name}/%{name}-common.dll*
smuxi.src:130: E: hardcoded-library-path in
%{_prefix}/lib/%{name}/%{name}-engine-campfire.dll*
smuxi.src:131: E: hardcoded-library-path in
%{_prefix}/lib/%{name}/ServiceStack.*.dll*
smuxi.src:132: E: hardcoded-library-path in
%{_prefix}/lib/%{name}/%{name}-engine-irc.dll*
smuxi.src:133: E: hardcoded-library-path in
%{_prefix}/lib/%{name}/Meebey.SmartIrc4net.dll*
smuxi.src:134: E: hardcoded-library-path in
%{_prefix}/lib/%{name}/%{name}-engine-jabbr.dll*
smuxi.src:135: E: hardcoded-library-path in
%{_prefix}/lib/%{name}/JabbR.Client.dll*
smuxi.src:136: E: hardcoded-library-path in
%{_prefix}/lib/%{name}/Microsoft.AspNet.SignalR.Client.dll*
smuxi.src:137: E: hardcoded-library-path in
%{_prefix}/lib/%{name}/%{name}-engine-twitter.dll*
smuxi.src:138: E: hardcoded-library-path in
%{_prefix}/lib/%{name}/Newtonsoft.Json.dll*
smuxi.src:139: E: hardcoded-library-path in
%{_prefix}/lib/%{name}/Twitterizer2.dll*
smuxi.src:140: E: hardcoded-library-path in
%{_prefix}/lib/%{name}/%{name}-engine-xmpp.dll*
smuxi.src:141: E: hardcoded-library-path in %{_prefix}/lib/%{name}/agsxmpp.dll*
smuxi.src:142: E: hardcoded-library-path in
%{_prefix}/lib/%{name}/StarkSoftProxy.dll*
smuxi.src:146: E: hardcoded-library-path in
%{_prefix}/lib/smuxi/smuxi-frontend-stfl.exe
smuxi.src:147: E: hardcoded-library-path in
%{_prefix}/lib/smuxi/smuxi-frontend-stfl.exe.config
smuxi.src:153: E: hardcoded-library-path in
%{_prefix}/lib/pkgconfig/smuxi-common.pc
smuxi.src:154: E: hardcoded-library-path in
%{_prefix}/lib/pkgconfig/smuxi-engine-irc.pc
smuxi.src:155: E: hardcoded-library-path in
%{_prefix}/lib/pkgconfig/smuxi-engine.pc
smuxi.src:156: E: hardcoded-library-path in
%{_prefix}/lib/pkgconfig/smuxi-frontend.pc
1 packages and 0 specfiles checked; 30 errors, 1 warnings.

A library path is hardcoded to one of the following paths: /lib, /usr/lib. It
should be replaced by something like /%{_lib} or %{_libdir}.

Solution:- Don't hardcode path in SPEC rather use macros.


2. the source package contains various types of License and must be corrected.

[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Apache (v2.0)", "LGPL (v2.1 or later) (with incorrect FSF address)",
     "GPL (v2 or later)", "Unknown or generated", "MIT/X11 (BSD like)", "BSD
     (3 clause)", "BSD", "GPL (v2 or later) (with incorrect FSF address)",
     "LGPL (v2.1 or later)". 1798 files have unknown license. Detailed output
     of licensecheck in

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]