Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-libwhisker2 - Perl module geared specificly for HTTP testing https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239096 ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-05-09 01:53 EST ------- OK, builds fine and rpmlint is quiet. You don't need "BuildRequires: perl" but it doesn't hurt anything to have it. Note for others who may check for BuildRequires: needed for the perl-devel split: this module doesn't build like a regular module and has a custom Makefile.pl which doesn't make use of the regular Perl build infrastructure. Yes, this package does at least try to use MD5 at some point although it will use an internal implementation if the module isn't available. At least according to my reading of src/mdx.pl. The only issue at this point that concerns me is the name of the package. Our naming guidelines indicate that packages should be named according to how they're carried in CPAN, but of course this module isn't in CPAN. According to CPAN rules it wold be called perl-LW2, but that seems somewhat suboptimal as well. Frankly I favor the current naming, but before I approve I'll gather a couple of other opinions. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review