https://bugzilla.redhat.com/show_bug.cgi?id=1073794 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |TomasM@xxxxxxxxx Flags| |needinfo?(TomasM@xxxxxxxxx) --- Comment #2 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- Naming: NOT Ok 1. MUST drop .TMM string from Release: tag license: ok sources: ok (would be nice to get a fresh snapshot, this one is fairly old by now) scriptlets: ok macros: ok (mostly) 2. SHOULD use newer %{qmake_qt5} macro instead of %{_qt5_qmake} %files: NOT ok 3. MUST package lib soname symlinks and *.prf files in -devel subpkg %{_qt5_libdir}/libQt53DQuick.so %{_qt5_libdir}/libQt53D.so %{_qt5_libdir}/libQt53D*.prl 4. MUST drop needless -static pkg, I'd recommend simply omitting *.la files from packaging scratch build underway: http://koji.fedoraproject.org/koji/taskinfo?taskID=8508245 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review