https://bugzilla.redhat.com/show_bug.cgi?id=1174097 Christopher Meng <i@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |i@xxxxxxxx --- Comment #9 from Christopher Meng <i@xxxxxxxx> --- This doesn't match our requirement: 1. # Group will be dropped when no distribution complains %if 0%{?rhel} || 0%{?centos} Group: Development/Languages %else # Drop group for fedora now, keep for others %if 0%{?fedora} == 0 Group: Development/Languages/Other %endif %endif Please, just drop them unless you're gonna package this for EPEL5. 2. Source: http://downloads.sourceforge.net/nodebrain/nodebrain-0.9.03.tar.gz Patch: nodebrain-0.9.03-messages.patch URL: http://nodebrain.org/ It's better to put URL tag above the Source tag. And, for the link in the source, use %version macro will help you reduce the time to update the URL. http://downloads.sourceforge.net/nodebrain/nodebrain-%{version}.tar.gz 3. %if 0%{?fedora} >= 19 || 0%{?rhel} >= 6 || 0%{?centos} >= 6 || 0%{?suse_version} >= 1200 %else BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) %endif I don't want to see any SUSE stuffs in Fedora package, I hope you can drop that. And for the buildroot tag, you don't need to use such a long conditional line to satisfy the rpmlint or whatever, just drop this. 4. %if 0%{?fedora} >= 19 || 0%{?centos} >= 6 || 0%{?suse_version} >= 1200 BuildRequires: pkgconfig(libedit) pkgconfig(libpcre) pkgconfig(openssl) gettext pkgconfig %else BuildRequires: pcre-devel openssl-devel gettext pkgconfig %endif I think it's just a waste of space. It doesn't mean that Fedora 18 can't do this job. 5. %prep %setup -q %patch -p1 %build %configure make %{?_smp_mflags} I hope you can leave a blank line above the %build. 6. %if 0%{?fedora} >= 19 || 0%{?rhel} >= 6 || 0%{?centos} >= 6 || 0%{?suse_version} >= 1200 %else %clean rm -rf %{buildroot} %endif Same applies to this. 7. Static packages are not welcome. https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries 8. Requires: pkgconfig Requires: %{name}%{?_isa} = %{version}-%{release} Requires: pcre-devel Requires: openssl-devel Requires: glibc-devel Drop R line of pkgconfig, if you install a pkgconfig file in this package, RPM will pick this dependency up automatically. 9. For the %{?_isa} macro, you should use it everywhere in -devel: https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package 10. %{_libdir}/*.so %exclude %{_libdir}/*.so.* %exclude %{_libdir}/nb-0 We always do like this: %files %{_libdir}/*.so.* %files devel %{_libdir}/*.so Put your plugins in main packages as well, as you've put them to a nb-0 directory, I think it's OK. But don't misinclude other unversioned library files in the main package. 11. I think you don't have to mention glibc in most of packages, it's a default dep of the basic system. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review