https://bugzilla.redhat.com/show_bug.cgi?id=1149407 --- Comment #4 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> --- Well, I will do review on mainly packaging issue. * Creating user - Is the shell of "rocci" user okay with /bin/bash? (/sbin/nologin preferred?) * Selinux related - Well, I don't know selinux handling in detail, so if I am wrong, please correct me. Now: * Status of log files - What selinux status does files under %{_localstatedir}/log/rocci-server/ after the final "removal" of rOCCI-server? Log files under %{_localstatedir}/log/rocci-server/ can remail undeleted after the removal of rOCCI-server rpm, and can't those files be undefined selinux state without again executing "restorecon" at %postun with "$1 == 0"? * Documentation - Can files under %{app_root}/examples/ moved to -doc subpackage? * Requires for rubygem(%{openssl_cms}) - By the way, not strictly for this package, however are there any reason why rubygem(%{openssl_cms}) has different naming between ruby 2.0 and ruby 2.1? Note that when gem contains C extension (under %gem_extdir_mri), C library dependency is correctly added by rpmbuild process (like libruby.so.2.1), and there should be no need to append additional suffix to %gem_name, e.g. http://koji.fedoraproject.org/koji/buildinfo?buildID=596281 http://koji.fedoraproject.org/koji/buildinfo?buildID=596282 Other things looks okay. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review