[Bug 1171624] Review Request: statismo - C++ Framework for building Statistical Image And Shape Models

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1171624



--- Comment #12 from Michael Schwendt <bugs.michael@xxxxxxx> ---
Consider pointing the "fedora-review" at this ticket: fedora-review -b 1171624

It performs a lot of package review tests on the src.rpm and any built rpms and
presents a list of what other issues might be relevant.


> %files
> %doc ReadMe.md
> %license LICENSE
> %{_libdir}/*.so.*
> 
> %files doc
> %doc ReadMe.md
> %license LICENSE
> %{_docdir}/%{name}/

Caution! %doc plus %_docdir inside the same spec file is non-trivial since
Fedora 20 and leads to duplication of files in subpackages:

  https://fedorahosted.org/fpc/ticket/338


> %files devel
> %{_libdir}/*.so
> %{_libdir}/cmake/%{name}/
> %{_includedir}/%{name}/

This would be a case of an "unowned directory" as hinted by Antonia in comment
8. You either need to include the directory %_libdir/cmake or "Requires: cmake"
to pull in the ownership from that package. If statismo-devel can be used
without CMake, including the directory is _okay_, see:

 
http://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function

Also:
https://lists.fedoraproject.org/pipermail/packaging/2014-December/010411.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]