https://bugzilla.redhat.com/show_bug.cgi?id=1175602 František Dvořák <valtri@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from František Dvořák <valtri@xxxxxxxxxx> --- I'm sorry for the delay (various holiday and other work stuff. :-)). Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Ruby: [x]: Platform dependent files must all go under %{gem_extdir_mri}, platform independent under %{gem_dir}. [x]: Gem package must not define a non-gem subpackage [x]: Macro %{gem_extdir} is deprecated. [x]: Gem package is named rubygem-%{gem_name} [x]: Package contains BuildRequires: rubygems-devel. [x]: Gem package must define %{gem_name} macro. [x]: Package does not contain Requires: ruby(abi). ===== SHOULD items ===== Generic: [x]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files (In generated docs) [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [x]: Package functions as described. OK: ruby -e "require 'glut'; p Glut:VERSION" [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Ruby: [-]: Test suite of the library should be run. Note: OK, not available and explained in the spec. [x]: Specfile should use macros from rubygem-devel package. [x]: Gem package should exclude cached Gem. [x]: Gem should use %gem_install macro. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rubygem-glut-8.2.1-1.fc22.i686.rpm rubygem-glut-doc-8.2.1-1.fc22.noarch.rpm rubygem-glut-8.2.1-1.fc22.src.rpm rubygem-glut.i686: W: spelling-error Summary(en_US) opengl -> opening rubygem-glut.i686: W: spelling-error %description -l en_US opengl -> opening rubygem-glut.i686: E: zero-length /usr/lib/gems/ruby/glut-8.2.1/gem.build_complete rubygem-glut.src: W: spelling-error Summary(en_US) opengl -> opening rubygem-glut.src: W: spelling-error %description -l en_US opengl -> opening 3 packages and 0 specfiles checked; 1 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- ]0;<mock-chroot><mock-chroot>[root@forkys2 /]# rpmlint rubygem-glut rubygem-glut-doc rubygem-glut.i686: W: spelling-error Summary(en_US) opengl -> opening rubygem-glut.i686: W: spelling-error %description -l en_US opengl -> opening rubygem-glut.i686: E: zero-length /usr/lib/gems/ruby/glut-8.2.1/gem.build_complete 2 packages and 0 specfiles checked; 1 errors, 2 warnings. ]0;<mock-chroot><mock-chroot>[root@forkys2 /]# echo 'rpmlint-done:' Requires -------- rubygem-glut (rpmlib, GLIBC filtered): libGL.so.1 libc.so.6 libcrypt.so.1 libdl.so.2 libglut.so.3 libm.so.6 libpthread.so.0 libruby.so.2.1 rtld(GNU_HASH) ruby(rubygems) rubygem-glut-doc (rpmlib, GLIBC filtered): rubygem-glut Provides -------- rubygem-glut: rubygem(glut) rubygem-glut rubygem-glut(x86-32) rubygem-glut-doc: rubygem-glut-doc Unversioned so-files -------------------- rubygem-glut: /usr/lib/gems/ruby/glut-8.2.1/glut/glut.so Source checksums ---------------- https://rubygems.org/gems/glut-8.2.1.gem : CHECKSUM(SHA256) this package : fb9e4b9d3b6995eef65de7ffbcc5390106d1306017295fdd2ae75ced5e70c889 CHECKSUM(SHA256) upstream package : fb9e4b9d3b6995eef65de7ffbcc5390106d1306017295fdd2ae75ced5e70c889 Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -b 1175602 -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Ruby, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG ===== No issues found. Some cosmetics things, which can be ignored (probably not worth mentioning :-)): - "opengl" could be written as "OpenGL" (as used in rubygem-opengl package) - copying of MRI is slightly different from the example in guidelines: mkdir -p %{buildroot}%{gem_extdir_mri} cp -a .%{gem_extdir_mri}/{gem.build_complete,*.so} %{buildroot}%{gem_extdir_mri}/ Package APPROVED! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review