https://bugzilla.redhat.com/show_bug.cgi?id=1174933 Miroslav Suchý <msuchy@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |msuchy@xxxxxxxxxx --- Comment #2 from Miroslav Suchý <msuchy@xxxxxxxxxx> --- Just reading the This: %clean rm -rf %{buildroot} Is not needed unless you target EL5. http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean The same apply for rm -rf %{buildroot} in %install Fedora 22 defaults to Python3. Unless you have strong reason, you should provide python3-* subpackage. This: %defattr(-,root,root,-) is default and is not needede since rpm4.2 It would be nice if you can provide man pages for: %{_bindir}/rqinfo %{_bindir}/rqworker (and maybe contribute it back to upstream). License should be: %license LICENSE Upstream have tests... you should run them in %check section. (you need to package them as SOURCEX) in %prep section you should delete bundled egg-info and create it from source http://fedoraproject.org/wiki/Packaging:Python_Eggs You should try to preserve timestamps of files. Therefore you "cp -a". Summary must not end with dot. Buildroot tag is not needed (unless you target el5) http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review