[Bug 1172719] Review Request: isl - Integer point manipulation library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1172719

Michael Schwendt <bugs.michael@xxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugs.michael@xxxxxxx



--- Comment #2 from Michael Schwendt <bugs.michael@xxxxxxx> ---
> expanded our pkgconfig_libdir... /usr/lib64/pkgconfig

That's what the build.log says, but you move it to %{_datadir}/pkgconfig/isl.pc
in %install. Why? Its contents are _not_ arch-independent.

Further, isl.pc relinks with -lgmp, which is not necessary when linking shared. 

And isl.pc doesn't specify a pkgconfig dependency on gmp/gmp-devel, because
that one does not include any pkgconfig file.


>   CC       isl_gmp.lo
>   CC       isl_ast_int.lo

Build output is non-verbose, which makes it almost useless. One cannot see the
linker and/or compiler options (
https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags )

Try building with V=1 passed to "make", or configure with
--disable-silent-rules. That may be enough. See --help.


> -rwxr-xr-x  /usr/lib64/libisl.la

These libtool archives are covered here:
https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries


> $ rpm -qpR isl-devel-0.14-1.fc21.x86_64.rpm |grep isl
> isl = 0.14-1.fc21
> libisl.so.13()(64bit)

https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package


> Requires: gmp

https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires


> Group: System Environment/Base

Group tag for C/C++ library -devel packages has been "Development/Libraries"
for many years.

The Group tag for your base package is missing. It would be "System
Environment/Libraries", but notice:

https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag


> %setup -q
> %configure

%configure is to be executed in %build (not just for --short-circuit builds).


> %install
> make install ...

Use %makeinstall:

https://fedoraproject.org/wiki/Packaging:Guidelines#Why_the_.25makeinstall_macro_should_not_be_used


> %defattr(-,root,root,-)

%defattr is not needed anymore for a long time:
https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions

Unless you want to reuse exactly the same spec for EL5.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]