Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Nmap-Parser - Parse nmap scan data with perl Alias: perl-Nmap-Parser https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239087 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tibbs@xxxxxxxxxxx ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-05-08 16:16 EST ------- I was typing this in before cweyl took this for review; hopefully the comments will still be useful. Some rpmlint complaints: E: perl-Nmap-Parser no-changelogname-tag The changelog is empty W: perl-Nmap-Parser spurious-executable-perm /usr/share/doc/perl-Nmap-Parser-1.05/README W: perl-Nmap-Parser spurious-executable-perm /usr/share/doc/perl-Nmap-Parser-1.05/LICENSE Executable README and LICENSE files? E: perl-Nmap-Parser wrong-script-end-of-line-encoding /usr/share/doc/perl-Nmap-Parser-1.05/README Perhaps this package came from DOS or something. All of the line endings need to be fixed up with a quick trip through tr or sed. W: perl-Nmap-Parser manifest-in-perl-module /usr/share/doc/perl-Nmap-Parser-1.05/MANIFEST The manifest file isn't to be packaged. W: perl-Nmap-Parser spurious-executable-perm /usr/share/doc/perl-Nmap-Parser-1.05/MANIFEST E: perl-Nmap-Parser wrong-script-end-of-line-encoding /usr/share/doc/perl-Nmap-Parser-1.05/MANIFEST Hmmm.... E: perl-Nmap-Parser script-without-shebang /usr/lib/perl5/vendor_perl/5.8.8/Nmap/Parser.pm This shouldn't be executable. Or, if it needs to be executable, it needs to have the usual #!/usr/bin/perl as its first line. E: perl-Nmap-Parser wrong-script-end-of-line-encoding /usr/lib/perl5/vendor_perl/5.8.8/Nmap/Parser.pm tr or sed again. Next, you'll need BuildRequires: perl(ExtUtils::MakeMaker,) perl(Test::More) so that your package will still build and run its tests once the perl-devel split from the main perl package is complete. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review