https://bugzilla.redhat.com/show_bug.cgi?id=1177038 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rdieter@xxxxxxxxxxxx Blocks| |928937 (qt-reviews) --- Comment #1 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- Initial comments: 1. License tag NOT ok. License: LGPLv21, LGPLv3, or GPLv2 is invalid. I'd suggest the following which matches what is currently used in other qt5 packages: # See LICENSE.GPL LICENSE.LGPL LGPL_EXCEPTION.txt, for details # See also http://qt-project.org/doc/qt-5.0/qtdoc/licensing.html License: LGPLv2 with exceptions or GPLv3 with exceptions 2. Please document (preferably in a .spec comment) why static libs are needed, BuildRequires: qt5-qtbase-static >= %{version} Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=928937 [Bug 928937] Qt-related package review tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review