Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Module-ExtractUse - Find out what modules are used Alias: Module-ExtractUse https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239193 ------- Additional Comments From ville.skytta@xxxxxx 2007-05-08 14:38 EST ------- (In reply to comment #2) > (In reply to comment #1) > > > - Rationale for including the t/ dir in docs? Doesn't look useful to me, > > neither does TODO. TODO is still included in -2. > * tests can make good documentation (sometimes better than the actual docs) I don't think that's the case in this package. > * people might actually want to test the package post-installation I'm pretty sure that people who install software from rpms don't expect to be able to do that, at least when not installing a *-test subpackage. I'm not saying it's necessarily a doomed idea, but should be discussed in distro wide context before starting to apply in packages here and there. > * it doesn't hurt anything :) * It does add files to the package payload that the overwhelming vast majority does not have use for. * Test suites are also often quick and dirty code which is not meant to be used as an example of anything. * Test suite code is not restricted to using the public API of the software; some features can be better tested using knowledge of module internals. We don't want anyone to use such code as an example how to use the packaged software. * Test suites have dependencies that the users need to take care of manually, or the package will be dependency bloated. Both are bad, and easily solved by not including the test suite. To summarize, I think including test suite code is acceptable if there's an upstream recommendation to use it as an example, upstream installs it too, and/or packaging test suites becomes a standard packaging practice (or there's a decision/consensus that things should move towards that). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review