[Bug 1123511] Review Request: nanomsg - A fast, scalable, and easy to use socket library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1123511

Michael Schwendt <bugs.michael@xxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugs.michael@xxxxxxx



--- Comment #9 from Michael Schwendt <bugs.michael@xxxxxxx> ---
Not much left:

* SONAME has not changed. It's still libnanomsg.so.0


* If you insist on creating a separate -doc package for only 39 files with a
total size of 1,021,705 bytes, also consider adding "BuildArch: noarch" to that
subpackage.



# pkg-config libnanomsg --libs
-lnanomsg -lanl -lrt 

Kinda odd to relink with libanl and librt since libnanomsg is linked with those
two already, and the nanomsg API does not pull in anything for those two libs:

  # grep .*#include /usr/include/nanomsg/*
  /usr/include/nanomsg/nn.h:#include <errno.h>
  /usr/include/nanomsg/nn.h:#include <stddef.h>
  /usr/include/nanomsg/reqrep.h:#include "nn.h"



The testsuite succeeds with this release, provided that the spec file points
the runtime linker at the freshly built lib:

--- nanomsg.spec.ORIG    2014-11-15 00:34:06.000000000 +0100
+++ nanomsg.spec    2014-12-25 15:42:38.301122955 +0100
@@ -115,7 +115,7 @@
 %check
 # conditional: currently failing tests:
https://github.com/nanomsg/nanomsg/issues/281
 %if %{with check}
-make check DESTDIR="%{buildroot}"
+LD_LIBRARY_PATH=$(pwd)/.libs make check
 %endif

============================================================================
Testsuite summary for nanomsg 0.5-beta
============================================================================
# TOTAL: 31
# PASS:  31
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]