Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: arping - Sends IP and/or ARP pings (to the MAC address) https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239470 Jochen@xxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |Jochen@xxxxxxxxxxxxxxx Flag| |fedora-review? ------- Additional Comments From Jochen@xxxxxxxxxxxxxxx 2007-05-08 13:34 EST ------- Good: + Naming seems ok. + Sources matches with upstream. + License seems ok. + Package contains verbatin copy of the license. + Mock build works fine. + Rpmlint is quite on binary rpm. Bad: - Local build fails with errors: sleep 3 In file included from arping-2/arping.c:48: /usr/include/libnet.h:87:2: error: #error "byte order has not been specified, you'll need to #define either LIBNET_LIL_ENDIAN or LIBNET_BIG_ENDIAN. See the documentation regarding the libnet-config script." arping-2/arping.c:94: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token arping-2/arping.c: In function 'do_libnet_init': arping-2/arping.c:128: error: 'libnet' undeclared (first use in this function) arping-2/arping.c:128: error: (Each undeclared identifier is reported only once arping-2/arping.c:128: error: for each function it appears in.) arping-2/arping.c:138: error: 'LIBNET_LINK' undeclared (first use in this function) arping-2/arping.c: In function 'pingmac_send': arping-2/arping.c:394: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'icmp' arping-2/arping.c:394: error: 'icmp' undeclared (first use in this function) arping-2/arping.c:394: error: 'ipv4' undeclared (first use in this function) arping-2/arping.c:394: error: 'eth' undeclared (first use in this function) arping-2/arping.c:404: error: 'libnet' undeclared (first use in this function) arping-2/arping.c:411: error: 'LIBNET_IPV4_H' undeclared (first use in this function) arping-2/arping.c:412: error: 'LIBNET_ICMPV4_ECHO_H' undeclared (first use in this function) arping-2/arping.c:424: warning: passing argument 9 of 'libnet_build_ipv4' makes pointer from integer without a cast arping-2/arping.c:424: warning: passing argument 10 of 'libnet_build_ipv4' makes integer from pointer without a cast arping-2/arping.c:424: error: too many arguments to function 'libnet_build_ipv4' arping-2/arping.c:435: error: too many arguments to function 'libnet_build_ethernet' arping-2/arping.c: In function 'pingip_send': arping-2/arping.c:462: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'arp' arping-2/arping.c:462: error: 'arp' undeclared (first use in this function) arping-2/arping.c:462: error: 'eth' undeclared (first use in this function) arping-2/arping.c:474: error: 'libnet' undeclared (first use in this function) arping-2/arping.c:475: error: too many arguments to function 'libnet_build_arp' arping-2/arping.c:486: error: too many arguments to function 'libnet_build_ethernet' arping-2/arping.c: In function 'pingip_recv': arping-2/arping.c:547: error: dereferencing pointer to incomplete type arping-2/arping.c:565: error: dereferencing pointer to incomplete type arping-2/arping.c:575: error: dereferencing pointer to incomplete type arping-2/arping.c: In function 'pingmac_recv': arping-2/arping.c:614: error: 'LIBNET_IPV4_H' undeclared (first use in this function) arping-2/arping.c:616: error: dereferencing pointer to incomplete type arping-2/arping.c:617: error: dereferencing pointer to incomplete type arping-2/arping.c:619: error: dereferencing pointer to incomplete type arping-2/arping.c:623: error: dereferencing pointer to incomplete type arping-2/arping.c:634: error: dereferencing pointer to incomplete type arping-2/arping.c:636: error: dereferencing pointer to incomplete type arping-2/arping.c:640: error: dereferencing pointer to incomplete type arping-2/arping.c:645: error: dereferencing pointer to incomplete type arping-2/arping.c:649: error: dereferencing pointer to incomplete type arping-2/arping.c:655: error: dereferencing pointer to incomplete type arping-2/arping.c:659: error: dereferencing pointer to incomplete type arping-2/arping.c: In function 'main': arping-2/arping.c:910: error: 'libnet' undeclared (first use in this function) arping-2/arping.c:983: warning: passing argument 1 of 'strdup' makes pointer from integer without a cast arping-2/arping.c:1023: warning: passing argument 1 of 'strdup' makes pointer from integer without a cast arping-2/arping.c:1128: error: too few arguments to function 'libnet_get_hwaddr' make: *** [arping-2/arping] Error 1 make: *** Waiting for unfinished jobs.... Fehler: Fehler-Status beim Beenden von /var/tmp/rpm-tmp.14424 (%build) - $RPM_OPT_FLAGS was not used during the build. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review