Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: slim - Simple Login Manager https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239428 Jochen@xxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |Jochen@xxxxxxxxxxxxxxx Flag| |fedora-review? ------- Additional Comments From Jochen@xxxxxxxxxxxxxxx 2007-05-08 11:44 EST ------- God: + Naming seems ok. + License seems ok. + Package contains verbatin copy of the license. Bad: - Rpmlint complaints on source rpm. W: slim strange-permission slim-update_slim_wmlist 0775 - Rpmlint complaints binary rpm W: slim dangling-relative-symlink /usr/share/slim/themes/default/background.jpg ../../../backgrounds/images/default.jpg W: slim no-version-in-last-changelog W: slim conffile-without-noreplace-flag /etc/slim.conf - Tar ball doesn't maches with upstream tar ball. 1bf891f046014a03236c21ce6cbe455b ../SOURCES/slim-1.2.6.tar.gz (RPM) 7a98d588cb6778baefcaa368f3dfa2a4 slim-1.2.6.tar.gz (Upstream) - Mockbuild fails with errors: freetype2/config -I/usr/include/libpng12 -I/usr/include -DPACKAGE=\"slim\" -DVERSION=\"1.2.6\" -DPKGDATADIR=\"/usr/share/slim\" -DSYSCONFDIR=\"/etc\" -DHAVE_SHADOW -c main.cpp -o main.o /usr/bin/g++ -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -I. -I/usr/X11R6/include -I/usr/include/freetype2 -I/usr/include/freetype2/config -I/usr/include/libpng12 -I/usr/include -DPACKAGE=\"slim\" -DVERSION=\"1.2.6\" -DPKGDATADIR=\"/usr/share/slim\" -DSYSCONFDIR=\"/etc\" -DHAVE_SHADOW -c image.cpp -o image.o In file included from panel.h:28, from app.h:23, from main.cpp:12: input.h:17:25: error: X11/Xft/Xft.h: No such file or directory image.cpp: In member function 'bool Image::Read(const char*)': image.cpp:71: warning: ignoring return value of 'size_t fread(void*, size_t, size_t, FILE*)', declared with attribute warn_unused_result panel.h:57: error: 'XftDraw' has not been declared panel.h:57: error: 'XftColor' has not been declared panel.h:57: error: 'XftFont' has not been declared panel.h:58: error: 'XftChar8' has not been declared panel.h:59: error: 'XftColor' has not been declared panel.h:71: error: ISO C++ forbids declaration of 'XftFont' with no type panel.h:71: error: expected ';' before '*' token panel.h:72: error: 'XftColor' does not name a type panel.h:73: error: 'XftColor' does not name a type panel.h:74: error: 'XftColor' does not name a type panel.h:75: error: 'XftColor' does not name a type panel.h:76: error: ISO C++ forbids declaration of 'XftFont' with no type panel.h:76: error: expected ';' before '*' token panel.h:77: error: 'XftColor' does not name a type panel.h:78: error: ISO C++ forbids declaration of 'XftFont' with no type panel.h:78: error: expected ';' before '*' token panel.h:79: error: ISO C++ forbids declaration of 'XftFont' with no type panel.h:79: error: expected ';' before '*' token panel.h:80: error: 'XftColor' does not name a type panel.h:81: error: 'XftColor' does not name a type panel.h:82: error: ISO C++ forbids declaration of 'XftFont' with no type panel.h:82: error: expected ';' before '*' token panel.h:83: error: 'XftColor' does not name a type panel.h:84: error: 'XftColor' does not name a type make: *** [main.o] Error 1 make: *** Waiting for unfinished jobs.... error: Bad exit status from /var/tmp/rpm-tmp.95810 (%build) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review