[Bug 1176882] Review Request: nodejs-tar-stream - A streaming tar parser and generator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1176882



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ Package built successful in mock (f22 x86_64)

+ rpmlint on generated rpms gave output
nodejs-tar-stream.noarch: W: only-non-binary-in-usr-lib
nodejs-tar-stream.noarch: W: dangling-symlink
/usr/lib/node_modules/tar-stream/node_modules/xtend /usr/lib/node_modules/xtend
nodejs-tar-stream.noarch: W: dangling-symlink
/usr/lib/node_modules/tar-stream/node_modules/readable-stream
/usr/lib/node_modules/readable-stream
nodejs-tar-stream.noarch: W: dangling-symlink
/usr/lib/node_modules/tar-stream/node_modules/end-of-stream
/usr/lib/node_modules/end-of-stream
nodejs-tar-stream.noarch: W: dangling-symlink
/usr/lib/node_modules/tar-stream/node_modules/bl /usr/lib/node_modules/bl
nodejs-tar-stream.src: W: strange-permission nodejs-tar-stream-dl-tests.sh
0755L
nodejs-tar-stream.src: W: invalid-url Source1:
nodejs-tar-stream-tests-v1.1.1.tar.bz2
2 packages and 0 specfiles checked; 0 errors, 7 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball:  d048774bddd96320151f7924bb51451aed6fe0b583b7e1ec050f56cd14945fb4
upstream tarball:  
d048774bddd96320151f7924bb51451aed6fe0b583b7e1ec050f56cd14945fb4

+ License is "MIT" and included in its own LICENSE file.

+ follows nodejs packaging guidelines.

Suggestions:
1) Fix the Source1 file name

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]