https://bugzilla.redhat.com/show_bug.cgi?id=1174288 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx Blocks| |177841 (FE-NEEDSPONSOR) Assignee|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flags| |fedora-review? --- Comment #4 from Parag AN(पराग) <panemade@xxxxxxxxx> --- I only had a look at spec file not yet done any scratch build but found some issues to be fixed 1) BuildRequire for gcc is not needed see https://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2 2) Requires: glibc is not needed as well 3) in %install section you don't need following as its automatically get cleaned rm -rf $RPM_BUILD_ROOT See https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag 4) you don't need now to specify %defattr(-,root,root,-) See https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions 5) %clean section is not needed for Fedora packaging. See https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review