https://bugzilla.redhat.com/show_bug.cgi?id=1161834 Michael Schwendt <bugs.michael@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugs.michael@xxxxxxx --- Comment #10 from Michael Schwendt <bugs.michael@xxxxxxx> --- A brief look: > Requires: gtk2 >= 2.24.24 > Requires: libgnome >= 2.32.1 > Requires: libxml2 >= 2.9.1 > Requires: gnome-vfs2 >= 2.24.4 > Requires: libgnomeui >= 2.24.5 > Requires: totem >= 3.10.1 > Requires: streamripper >= 1.64.6 https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires That section is not specific to library packages. > %install > > %make_install > make DESTDIR=%{buildroot} install Double-check this %install section, please. Run "rpm -E %make_install" as a hint. > %lang(cs) > %lang(pt_BR) No-op and hence should be deleted. > %{_datadir}/girl/girl-0.1.dtd https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership https://fedoraproject.org/wiki/Packaging:UnownedDirectories %{_datadir}/appdata/girl.appdata.xml https://fedoraproject.org/wiki/Packaging:Guidelines#AppData_files https://fedoraproject.org/wiki/Packaging:AppData Note the bottom about validating the file. %{_datadir}/applications/girl.desktop https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage > %{_datadir}/icons/hicolor/16x16/apps/girl.png > %{_datadir}/icons/hicolor/22x22/apps/girl.png > %{_datadir}/icons/hicolor/24x24/apps/girl.png > %{_datadir}/icons/hicolor/32x32/apps/girl.png > %{_datadir}/icons/hicolor/48x48/apps/girl.png > %{_datadir}/icons/hicolor/256x256/apps/girl.png https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache > %{_mandir}/man1/girl.1.gz A growing number of reviewers suggest replacing the '.gz' with '*', because that makes it possible to disable/change/customise the compression that is applied by rpmbuild on-the-fly. %{_mandir}/man1/girl.1* -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review