https://bugzilla.redhat.com/show_bug.cgi?id=1159660 --- Comment #7 from Rich Mattes <richmattes@xxxxxxxxx> --- Yeah that original spec was a big crufty mess... The package is simple enough that an all-new spec file is probably less work than sorting out the original. It looks pretty good now. As far as your notes go: - I think noreplace was the right way to go, otherwise local changes get blown away on every package update. The fedora-review warning was probably trying to make sure you weren't trying to do the wrong thing. - According to [1], it's OK to own dirs from other packages in the case where the other package doesn't provide any core functionality for your package. If you don't need logrotate, you should own the directory, otherwise you need a Requires: logrotate. - I think systemd is the right call for epel7. It's the supported init system now, so providing native service files over sysv init files is preferable. The only argument I can see for shipping the init script is el6->el7 upgrades, but el7 has been out long enough that it's probably not a huge issue. As for The Big Checklist goes, everything is now fixed except for: - The logrotate.d directory ownership - According to [2], you need to BR python2-devel or python3-devel. [1] https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function [2] https://fedoraproject.org/wiki/Packaging:Python#BuildRequires -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review