https://bugzilla.redhat.com/show_bug.cgi?id=1132671 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #6 from Vít Ondruch <vondruch@xxxxxxxxxx> --- * The spec file differs from SRPM - There is BR: rubygem(sass-globbing) enabled in SRPM while disabled in the .spec you provided. The latter seems to be what you probably wanted. * Test suite - It seems that sed -i '/sass-globbing/ s/^/#/' test/test_helper.rb mv test/fixtures/with_globbing.scss{,.disable} Should be enough to execute the test suite without sass-globbing. * Patching using %patch0 macro - I'd suggest to apply the patch using "%patch0 -p1" in %prep section instead of the %build section. Otherwise, the package looks good => APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review