https://bugzilla.redhat.com/show_bug.cgi?id=1132670 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #6 from Vít Ondruch <vondruch@xxxxxxxxxx> --- * Test suite - I'd suggest to execute the test suite using following command: ruby -Ilib:test/units \ -e 'Dir.glob "./test/units/*_test.rb", &method(:require)' - Please expand the test suite in %check section. This way you keep in RPM just the content which was originally shipped by upstream. This also avoids several rpmlint complains. - It seems that the timecop and true are needed just for integration tests. Since there is circular dependency between true and compass, I'd suggest to use boostrap macro [1] to disable the integration tests during bootstrap. Otherwise the package is legit => APPROVED [1] https://fedoraproject.org/wiki/Packaging:Guidelines#Bootstrapping -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review