Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pyBackPack (GTK+ Python backup tool) https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221884 ------- Additional Comments From bjohnson@xxxxxxxxxxxx 2007-05-08 05:37 EST ------- (In reply to comment #7) > Any feedback for the 0.5.0 package? Working about the same as last release, as expected. > Aside: Last month I got pybackpack 0.5.0 sponsored into Debian unstable so > hopefully I'll get some good contextual feedback from that and it'll mature > better off the back of it. That should help. Here's a few things I noticed when I again recently looked at your spec file: 1) warning from rpm when building: warning: File listed twice: /usr/lib/python2.4/site-packages/pybackpack/backuptool.py That's because of this line: %attr(755,root,root) %{python_sitearch}/pybackpack/backuptool.py take that out and either chmod it in %install after it's installed, or even better since you're upstream, fix the install script :) (does it even need to be executable?) 2) /usr/lib/python2.4/site-packages/pybackpack/pybackpack_logo.png should go in /usr/share/pixmaps 3) /usr/share/applications/fedora-pybackpack.desktop specifies icon as "file-roller"? huh? 4) just replace all of this: %dir %{python_sitearch}/pybackpack %attr(755,root,root) %{python_sitearch}/pybackpack/backuptool.py %{python_sitearch}/pybackpack/*.py %{python_sitearch}/pybackpack/*.glade %{python_sitearch}/pybackpack/*.pyc %{python_sitearch}/pybackpack/*.png with this: %{python_sitearch}/* 5) you really don't want this: %ghost %{python_sitearch}/pybackpack/*.pyo -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review