https://bugzilla.redhat.com/show_bug.cgi?id=1176273 --- Comment #4 from MartinKG <mgansser@xxxxxxxx> --- Hi Raphael, thanks for your reply, (In reply to Raphael Groner from comment #3) > Hi Martin, > > there are some hints for your spec file. Maybe I can do the official review > as well. > > * SHOULD consider to name the package 'asqp' as upstream does partly for the > project name? Well, I can see that the source tarball is using that full > name like in the subject. > https://fedoraproject.org/wiki/Packaging:NamingGuidelines#General_Naming > ok, i will name the package/spec file asgp/asgp.spec > * SHOULD remove the Group tag cause it's obosolete. Note: This tag is > deprecated since Fedora 17. > https://fedoraproject.org/wiki/ > How_to_create_an_RPM_package#SPEC_file_overview > done > * MUST use a valid Source URL, or add a comment how to build the tarball. > https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL > > This? > http://www.stuff-o-matic.com/asgp/download/download.php?platform=source > yes this is a valid link for asgp-1.0.8 but there is a recent version 1.0.12 on https://github.com/j-jorge/asgp/ build instruction: mkdir asgp-build cd asgp-build git clone https://github.com/j-jorge/bear.git git clone https://github.com/j-jorge/asgp.git [root@fc21 asgp-build]# du -sk * 1140264 asgp 37616 bear approx. 1,17 GByte should we use this version ? > > * MUST build with mock and koji (scratch) to ensure all BR are correct. > https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires > https://fedoraproject.org/wiki/Using_the_Koji_build_system#Scratch_Builds > already done, but no additional build requires are detected. > * SHOULD fix/patch CMakeLists.txt to not enforce docbook2x as it seems to > create conflicts. And please send your patch to upstream, do they know about > that issue? > https://fedoraproject.org/wiki/Packaging: > Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment > > # Cmake suggests it but "parser error" will be got. > > BuildConflicts: docbook2x > can you send me a patch ? > * SHOULD what is "Plee the Bear"? How is it related to this package? You > won't be able to create two individual subpackges for that 'bear' and > 'bear-factory' stuff. So consider to package that separately and unbundle. > https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries > > of the Bear Engine for Plee the Bear & Andy's Super Great Park. > not done, because not clear. > * MUST 'Require: hicolor-icon-theme' cause of the folder ownership. > https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/ > Guidelines#File_and_Directory_Ownership > > %files > > … > > %{_datadir}/icons/hicolor/*/apps/asgp.png > added Require: hicolor-icon-theme is this ok ? > * MUST (when possible) use the %cmake macro to avoid relisting of all those > parameters like RPATH etc. > https://fedoraproject.org/wiki/Packaging:Cmake - done, replaced cmake with %cmake Spec URL: https://martinkg.fedorapeople.org/Review/asgp-1.0.8-3/asgp.spec %changelog * Sat Dec 20 2014 Martin Gansser <martinkg@xxxxxxxxxxxxxxxxx> - 1.0.8-3 - changed package name from andy-super-great-park to asgp - added valid Source URL - added download instruction - removed group tag - added CMAKE_VERBOSE_MAKEFILE=TRUE to %%make build verbose - added Require hicolor-icon-theme - used macro %%cmake -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review