[Bug 1175878] Review Request: nodejs-html-minifier - HTML minifier with lint-like capabilities

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1175878

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ Package built successful in mock (f22 x86_64)

+ rpmlint on generated rpms gave output
nodejs-html-minifier.noarch: W: only-non-binary-in-usr-lib
nodejs-html-minifier.noarch: W: dangling-symlink
/usr/lib/node_modules/html-minifier/node_modules/change-case
/usr/lib/node_modules/change-case
nodejs-html-minifier.noarch: W: dangling-symlink
/usr/lib/node_modules/html-minifier/node_modules/clean-css
/usr/lib/node_modules/clean-css
nodejs-html-minifier.noarch: W: dangling-symlink
/usr/lib/node_modules/html-minifier/node_modules/cli /usr/lib/node_modules/cli
nodejs-html-minifier.noarch: W: dangling-symlink
/usr/lib/node_modules/html-minifier/node_modules/uglify-js
/usr/lib/node_modules/uglify-js@2
nodejs-html-minifier.noarch: W: dangling-symlink
/usr/lib/node_modules/html-minifier/node_modules/relateurl
/usr/lib/node_modules/relateurl
nodejs-html-minifier.src: W: strange-permission
nodejs-html-minifier-dl-tests.sh 0755L
nodejs-html-minifier.src: W: invalid-url Source1:
nodejs-html-minifier-tests-v0.6.9.tar.bz2
2 packages and 0 specfiles checked; 0 errors, 8 warnings.


+ Source verified with upstream as (sha256sum)
srpm tarball: 5e58d4e5bb59ed6b24da67b822f30af8f016d3d19331981c1aea8f9349a7047b
upstream tarball: 
5e58d4e5bb59ed6b24da67b822f30af8f016d3d19331981c1aea8f9349a7047b

+ License is "MIT" and included in its own LICENSE file.

+ follows nodejs packaging guidelines.

Suggestions:
1) Group tag is optional and can be removed.

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]