https://bugzilla.redhat.com/show_bug.cgi?id=1176307 Raphael Groner <projects.rg@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #1 from Raphael Groner <projects.rg@xxxxxxxx> --- Hi Ivan, there are some hints for your spec file. Please fix those, then I can continue with the review. * Use macros whereever possible. Don't use a slash at the end of the URL. You can use just 'sf' as abbreviation 'sourceforge'. - URL: http://sourceforge.net/projects/torrent-file-editor/ + URL: http://sf.net/projects/%{name} - Source0: http://sourceforge.net/projects/%{name}/files/%{name}-%{version}.tar.gz + Source0: %{url}/files/%{name}-%{version}.tar.gz * MUST 'Require: hicolor-icon-theme' cause of the folder ownership. https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#File_and_Directory_Ownership > %files > … > %{_datadir}/icons/hicolor/*/apps/%{name}.png * SHOULD tell us more about your package in %description. Consider to write about the features as mentioned so at the sourceforge page. * SHOULD directly get the source tarball from github without using sourceforge https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Github * Additional question: Why do you not use Qt5 also in Fedora, like you do for the tree product? Fedora 21 has Qt5 packages. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review