https://bugzilla.redhat.com/show_bug.cgi?id=1172525 --- Comment #12 from Vladimir Stackov <amigo.elite@xxxxxxxxx> --- (In reply to Mikolaj Izdebski from comment #11) > Overally the package looks good. First some comments, then the actual > review. Once licensing problems are fixed I will approve the package > and sponsor you. Ok, thanks! I'm also removing request from FE-NEEDSPONSOR blockers. > > Hardening: It is not required for this package, but you can enable it > (or not) at your own discretion. For more information see [1]. If you > decide to enable hardening then you should be aware of negative > performance impact it can have. I think that we can keep it enabled > for now, but I'd recommend to compare performance with and without > hardening and decide whether keep it enabled or not. I'd prefer to have hardening enabled. Who wants to increase performance could easily rebuild package with specific flags. I'll also perform some tests and publish results in zbackup wiki. > > Licensing: As I understand, zbackup is licensed under GPL version 2 or > later with additional OpenSSL exception -- no actual zbackup code is > licensed under OpenSSL license. If that's the case then license tag > should be "GPLv2+ with exceptions". LICENSE-OPENSSL file shouldn't be > installed in this case as it doesn't apply to zbackup itself. Done. > > You should install CONTRIBUTORS file as %doc. See [2]. There is no CONTRIBUTORS in 1.3. The reason for preserving version in this request I've described in off-list reply. > > There is no good reason to use macros like %{__install} and such. You > should just use plain command names (mkdir, make, install) for better > spec file readability. Hmm, I'm always using as many macroses as possibly for portability reasons. Fixed anyway. > > I don't like the manpage. We can keep it as-is for now, but I think > that the goal should be writing proper manual page (this is upstream > work). Ok, I'll write it. https://github.com/zbackup/zbackup/issues/34 > > In changelogs we usually reference bugs as rhbz#1172525. Links to > Bugzilla are best avoided. Done. > > [1] http://fedoraproject.org/wiki/Packaging:Guidelines#PIE > [2] http://fedoraproject.org/wiki/Packaging:Guidelines#Documentation [..] SPEC: https://raw.githubusercontent.com/Am1GO/zbackup-rpm/master/zbackup.spec SRPM: https://github.com/Am1GO/zbackup-rpm/raw/master/zbackup-1.3-4.fc20.src.rpm Build task: http://koji.fedoraproject.org/koji/taskinfo?taskID=8443902 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review