https://bugzilla.redhat.com/show_bug.cgi?id=1172800 --- Comment #6 from Petr Machata <pmachata@xxxxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #5) > The way the version is defined is unusual. Why not simply remove %{commit} > and use %{version} everywhere instead? Done. This was a remnant of when I started working on the package using an as-yet-untagged GIT tree. > Use %license not %doc for COPYING COPYING-LGPLV3. You could also duplicate Done. > that in the -devel package, without depending on an implicit dependency. I know. I chose not to in accordance with packaging guidelines. > Not strictly necessary, but it would save a few lines to do: > make -C build install ... > > make -C build test I actually like how pushd/popd is used consistently to handle this across sections. > Requires: elfutils-devel%{?_isa} = %{version}-%{release} is bad. This makes Oops, yeah, that's probably too much copy-paste. > I think the "dwgrep-" component in library subpackages is unnecessary. Just > call them libzwerg, libzwerg-devel (use %package -n libzwerg, etc.). Oh, cool, I didn't know this was allowed. > You must add Provides: bundled(jquery). I don't think I bundle jquery. Do I bundle jquery? Thanks for review. I'll push an updated package shortly, spinning a test build now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review