[Bug 1166721] Review Request: python-javaobj - Python module for serializing and deserializing Java objects

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1166721



--- Comment #2 from Raphael Groner <projects.rg@xxxxxxxx> ---
Hi Mat,

thanks for the review.

> Please add comments about the separate COPYRIGHT file, where is this from? 
> Query upstream to include a copy of the license if they do not do so.
The Apache license suggests/recommends/requires to include such a file, so I've
created one as a starting point:
http://www.apache.org/licenses/LICENSE-2.0 →APPENDIX
Well, the project moved / seems to fork at github with the same name:
https://github.com/tcalmant/python-javaobj

> Description contains lines longer than 80 characters
fixed.

> Package must BR: python2-devel or python3-devel 
I want to delay a python3 package for now because I do not yet actively use Py3
but I should, you should not have to tell me that. ;)

> "maven-local" will pull all of these in for you
fixed.

> Rpmlint warnings about macros in comments
fixed / gone.

>  Does upstream expect this test to pass and have you reported the problem to them?
I guess upstream is aware about the outdated opcodes, there are already some
bugs at upstream mentioned with issues at newer java classes or the like. Let's
assume that's not that easy to fix. Somehow this module is also available via
PyPi, the last commit is from end of 2012 (see my adjustment to release tag).
And again, the fork at github looks better: The readme mentions the failing
swing test as TODO.

-
Release #0.3:
Spec URL:
https://raphgro.fedorapeople.org/review/py/python-javaobj/python-javaobj.spec
SRPM URL:
https://raphgro.fedorapeople.org/review/py/python-javaobj/python-javaobj-0-0.3.20131228gitb8ae821.fc20.src.rpm
build rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=8439290

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]