[Bug 1151842] Review Request: apx - QIX clone, cut into and claim the square area

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1151842



--- Comment #12 from Raphael Groner <projects.rg@xxxxxxxx> ---
(In reply to Eduardo Mayorga from comment #11)
> Yes, cairo is needed, so please readd it.

fixed.

> I'd suggest to include the setup.py as a patch, but that's up to you.

Since upstream has not suggested a better one, and I like the idea of using rpm
macros, I would keep going for now with the embedded setup.py template.

> The packaging of the font looks good to me as it is not released by upstream
> in a separated archive.

Again: It's a redistribution, already enforced at upstream. Till there is no
own fonts package in Fedora with all the up-upstream files, I think it's okay
for now to have this font as a subpackage and wait for a bug report about
further unbundling, still some headache.

Thanks for the review!

-
Release #0.5:
(mind the new apx subfolder)

Spec URL: https://raphgro.fedorapeople.org/review/hamster/apx/apx.spec
SRPM URL:
https://raphgro.fedorapeople.org/review/hamster/apx/apx-0-0.5.20141101gite7766f1.fc20.src.rpm
build rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=8438211

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]