https://bugzilla.redhat.com/show_bug.cgi?id=1175312 --- Comment #1 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- Naming: OK (mostly) (I think I'd prefer to simply call this "milou", without the artificial plasma- prefix, but we're already using that in other plasma applets, so maybe it's too late to reverse course now) 1. URL Not OK Please use, URL: https://projects.kde.org/projects/kde/workspace/milou 2. SHOULD not use %make_install macro (not recommended by packaging guidelines... yet) I'd prefer: make install/fast DESTDIR=%{buildroot} -C %{_target_platform} over %make_install -C %{_target_platform} macros: NOT OK 3. SHOULD use %_kf5_qmldir macro replace %{_qt5_prefix}/qml/org/kde/milou with %{_kf5_qmldir}/org/kde/milou/ sources: OK b99660be2145dae3144e8e004c649ec6 milou-5.1.1.tar.xz licensing: OK scriptlets: OK -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review