https://bugzilla.redhat.com/show_bug.cgi?id=1121115 --- Comment #7 from Jan Synacek <jsynacek@xxxxxxxxxx> --- Comments inlined: ===== MUST items ===== [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 23 files have unknown license. Detailed output of licensecheck in /home/jsynacek/work/reviews/axmail/1121115-axmail/licensecheck.txt LICENSE file present and is a GPLv2. Bundled files are most likely GPL compatible as mentioned in https://lists.fedoraproject.org/pipermail/legal/2014-July/002488.html. [ ]: Package must own all directories that it creates. Note: Directories without known owners: /etc/ax25 There already is a request to libax to provide that directory. ===== SHOULD items ===== [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: ftp://ftp.n1uro.net/packet/axmail-2.0.tar.gz See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags Manual download works. Rpmlint ------- Checking: axmail-2.0-1.fc20.x86_64.rpm axmail-2.0-1.fc20.src.rpm axmail.x86_64: W: spelling-error Summary(en_US) addon -> ad don, ad-don, add on axmail.x86_64: E: dir-or-file-in-var-lock /var/lock/axmail It's a ghost file, I don't see a problem with that. I don't think that ghosting a lock file is really necessary, though, but I'll leave this to the packager. axmail.x86_64: E: incorrect-fsf-address /usr/share/doc/axmail/copying Please, notify upstream about this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review