https://bugzilla.redhat.com/show_bug.cgi?id=1172141 Matthias Runge <mrunge@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |mrunge@xxxxxxxxxx Flags| |fedora-review+ --- Comment #12 from Matthias Runge <mrunge@xxxxxxxxxx> --- Adrien, your spec file has a few glitches, as noted above. But it is acceptable. Personally, I'd specify file names more explicit and remove rhel5 references or make it more conditional. I'd expect this to fail building on rawhide sooner or later, since tools are evolving. If you were my mentee, I'd also require you to list changes made during review process in changelog and bump the revision. But in general, that's a matter of personal preference. I reviewed the package again, and didn't found anything blocking us here. Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review