Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Berusky - 2D logic game based on an ancient puzzle Sokoban. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237416 ------- Additional Comments From Jochen@xxxxxxxxxxxxxxx 2007-05-07 13:21 EST ------- Good: + Namings seems ok. + Tar ball matches with upstream. Bad: - Mock build fails for berusky-1.1. aking all in src make[2]: Entering directory `/builddir/build/BUILD/berusky-1.1/src' if g++ -DHAVE_CONFIG_H -I. -I. -I.. -Wall -g -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -MT 2d_graph.o -MD -MP -MF ". deps/2d_graph.Tpo" -c -o 2d_graph.o 2d_graph.cpp; \ then mv -f ".deps/2d_graph.Tpo" ".deps/2d_graph.Po"; else rm -f ".deps/2d_graph.Tpo"; exit 1; fi if g++ -DHAVE_CONFIG_H -I. -I. -I.. -Wall -g -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -MT animation.o -MD -MP -MF " .deps/animation.Tpo" -c -o animation.o animation.cpp; \ then mv -f ".deps/animation.Tpo" ".deps/animation.Po"; else rm -f ".deps/animation.Tpo"; exit 1; fi if g++ -DHAVE_CONFIG_H -I. -I. -I.. -Wall -g -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -MT berusky.o -MD -MP -MF ".d eps/berusky.Tpo" -c -o berusky.o berusky.cpp; \ then mv -f ".deps/berusky.Tpo" ".deps/berusky.Po"; else rm -f ".deps/berusky.Tpo"; exit 1; fi berusky.cpp:33:20: error: curses.h: No such file or directory if g++ -DHAVE_CONFIG_H -I. -I. -I.. -Wall -g -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -MT berusky_gui.o -MD -MP -MF ".deps/berusky_gui.Tpo" -c -o berusky_gui.o berusky_gui.cpp; \ then mv -f ".deps/berusky_gui.Tpo" ".deps/berusky_gui.Po"; else rm -f ".deps/berusky_gui.Tpo"; exit 1; fi make[2]: *** [berusky.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[2]: Leaving directory `/builddir/build/BUILD/berusky-1.1/src' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/builddir/build/BUILD/berusky-1.1' make: *** [all] Error 2 I assume, that you have to add ncurses-devel at an BR. Best Regards: Jochen Schmitt -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review