[Bug 1175023] Review Request: oggify - audio conversion tool for music library conversion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1175023

Niranjan MR <niranjan@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |niranjan@xxxxxxxx



--- Comment #2 from Niranjan MR <niranjan@xxxxxxxx> ---
Greetings, 

This is un-official review of the package. The source mentioned in the spec
file cannot be downloaded.

1. Source:

Source0:   
https://github.com/%{owner}/%{project}/archive/%{project}-%{version}.tar.gz

wget https://github.com/spr/Oggify/archive/Oggify-2.0.7.tar.gz
--2014-12-18 02:34:05-- 
https://github.com/spr/Oggify/archive/Oggify-2.0.7.tar.gz
Resolving github.com (github.com)... 192.30.252.128
Connecting to github.com (github.com)|192.30.252.128|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://codeload.github.com/spr/Oggify/tar.gz/Oggify-2.0.7
[following]
--2014-12-18 02:34:07-- 
https://codeload.github.com/spr/Oggify/tar.gz/Oggify-2.0.7
Resolving codeload.github.com (codeload.github.com)... 192.30.252.145
Connecting to codeload.github.com (codeload.github.com)|192.30.252.145|:443...
connected.
HTTP request sent, awaiting response... 404 Not Found

2. License.

Please refer to https://fedoraproject.org/wiki/Licensing:Main for the License
to be mentioned in spec file. 

It's mentioned as GNU GPLv2 or later, it should be GPLv2+

3. Also run rpmlint on the srpm and correct all the errors.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]