[Bug 1150566] Review Request: wcm - Wal Commander

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1150566



--- Comment #3 from Eugene A. Pivnev <ti.eugene@xxxxxxxxx> ---
(In reply to amigo.elite from comment #1)

> You should use %license for LICENSE instead of %doc.

Fixed

> There is no man file. You should probably need to work with upstream to
> write it. It could be written in markdown and you could always convert it to
> man while packaging, e.g.
> 
> %build
> pandoc -s -f markdown_github -t man -V title=%{name} -V section=1 -V
> date="$(LANG=C date -d @$(stat -c'%Z' README.md) +'%B %d, %Y')" README.md -o
> %{name}.1

It is not CLI application and has no any CLI option.
Seems man is not required.

> Remove any comments from SPEC that you don't need.

Fixed.

> Replace spaces to tabs (line 25).

Fixed.
(Note: qterminal ^c-^v bag :-)

> You might want your SPEC to produce hardened binaries
> (http://fedoraproject.org/wiki/Packaging:Guidelines#PIE).

Done.

> Ah, I also need to mention that description must not be over 80 columns per line so you should split it into multiple lines.

Fixed (removed "multi-platform open source").

> Please note that this is informal review.

Ok

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]