Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: roundcubemail - Round Cube Webmail is a browser-based multilingual IMAP client https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225575 ------- Additional Comments From bjohnson@xxxxxxxxxxxx 2007-05-07 02:06 EST ------- (In reply to comment #24) > Please note that this is not roundcube or php support forum. Well, perhaps if I had written "roundcubemail RPM" claims to support sqlite... you'd have gotten what I meant. This is a package review. If the package has information that indicates that you can use sqlite and you in fact can not, then that will lead to a poor user experience (and many bug reports). And it is things like this, among many others, that I'm checking for. (In reply to comment #25) > Actually, I forget the name off the top of my head, but depending on how > roundcube is coded, it may work with the PHP PDO SQLite package, already in fedora. You may be right (PHP is definately not my expertise). However, everything that I've been able to read about the PDO sqlite extension implies that it's not a drop in replacement. Unless someone can show that it works with roundcubemail, I think we are going to have to assume that it does not. This is too bad, because it would be nice to have sqlite as the default out of the box experience. This would allow you to install the package and have it immediately work against an existing imap server without messing around with configuration files and setting up a mysql/pgsql database, which is quite a pain for this simple of an application. Unless it can be shown to work with sqlite, I think we should remove the example line in db.inc.php. There's no point in giving it as an example if it simply won't work. This also warrants a README.fedora file in %doc to explain database support available, lack of sqlite support, and basic instructions for settings up (or pointing to included docs - maybe the INSTALL file?) database support. Here are some things that I've noticed so far that need corrected: 1) /usr/share/roundcubemail/{CHANGELOG,INSTALL,LICENSE,README,UPGRADING} should be removed. 2) Rather than creating symlinks from /usr/share/roundcubemail to other directories, I think it would be more clear to edit the main.inc.php with the real paths. The indirection of symbolic links don't buy you anything. in %prep, for example: sed -i 's|temp/|/tmp/|' main.inc.php and again for log dir, and config (in program/include/main.inc) 3) I'm still looking into the security implications of having a static des_key. This might be a candidate for automatic generation in %post. 4) move SQL to %doc 5) /var/log/roundcubemail should have %attr(0775,root,apache), currently it is unwritable by apache process 6) Package should require httpd 7) Install *.dist files as regular config files, we know they have to be changed anyway at this point, and the error that roundcubemail reports with them installed or not installed is the same. 8) /etc/roundcubemail/* should be mode 640 (contain sensitive information) 9) would appreciate lines between changelog entries as it's easier to read :) 10) What's up with the versioning? http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-d97a3f40b6dd9d2288206ac9bd8f1bf9b791b22a 11) Need to investigate selinux policy for package. More to come later. You can rebuild the rpm with these changes or we can discuss anything here that you think is not appropriate. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review