https://bugzilla.redhat.com/show_bug.cgi?id=1174030 --- Comment #1 from Jan Chaloupka <jchaloup@xxxxxxxxxx> --- VALID - BuildRequires are correct - license is correct 1) Provides: golang(%{import_path}) = %{version}-%{release} The source codes itself does not contain any *.go files in its root directory. So we should not provide such import paths. However, it is root directory, source codes'prefix. This could be an exception as a way how to shorten all BuildRequires so we don't have to BuildRequire more import paths of the same package. On the other hand, the import paths can be distributed among more subpackages. BuildRequire could become invalid. So I recommend to remove this Provide. 2) CONTRIBUTING.md and SPEC.md should be in %files too as they give more information about the source codes Otherwise it look ok so far -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review