[Bug 1141878] Review Request: nodejs-es6-transpiler - es6 -> es5

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1141878



--- Comment #5 from Piotr Popieluch <piotr1212@xxxxxxxxx> ---
It seems that there are bundled libraries in the package. See jshint_global and
lib dirs. I think you should work with upstream to unbundle them or could they
be marked as copylibs?

I am not sure how to handle this, will ask my sponsor (Parag) if he is willing
to take a look.



Besides the bundled libs I found some other issues which are fixable, see:



When running the binary I get this error:

~  /usr/bin/es6toes5                                                
/usr/bin/env: node --harmony: No such file or directory

I can get around it by changing 
#!/usr/bin/env node --harmony
to
#!/usr/bin/node --harmony


After that it fails with:
Error: Cannot find module './es6-transpiler'

You can fix that by installing es6toes5 in the module directory and making a
symlink in /usr/bin/


There are two directories not packaged which are needed for functioning:
- transpiler
- jshint_globals


Bundled libraries:
jshint_globals is a bundled library, I think this could be fixed by using
https://www.npmjs.com/package/jshint-globals or could it be marked as a
copylib?

lib dir:
I have checked two files in lib dir which were both bundled libraries.
- esprima_harmony.js 
- error.js is from lib/esprima_harmony is a bundled library



All files have windows line endings, rpmlint warns about:

nodejs-es6-transpiler.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/nodejs-es6-transpiler/README.md
nodejs-es6-transpiler.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/nodejs-es6-transpiler/LICENSE

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]