https://bugzilla.redhat.com/show_bug.cgi?id=1166916 Björn "besser82" Esser <bjoern.esser@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #1 from Björn "besser82" Esser <bjoern.esser@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [!]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. ---> Cannot find any license-info in package, license-file nor sources… [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 23 files have unknown license. Detailed output of licensecheck in /home/besser82/shared/fedora/review/1166916-fuzzynet/licensecheck.txt ---> Cannot verify license… [-]: License file installed when any subpackage combination is installed. [-]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [!]: Sources contain only permissible code or content. ---> License?!? [-]: Package contains desktop file if it is a GUI application. [!]: Development files must be in a -devel package ---> There are no devel-files but only documentation in -devel-pkg. [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). ---> Execption for /usr/lib/ with Mono. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [!]: Spec file is legible and written in American English. ---> See remarks below… [-]: Package contains systemd file(s) if in need. [!]: Useful -debuginfo package or justification otherwise. ---> Empty debuginfo [!]: Package is not known to require an ExcludeArch tag. ---> There are arches known which are not working with Mono… [!]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 184320 bytes in 21 files. ---> Move the documentation to the main-pkg and drop the devel-pkg, please. [!]: Package complies to the Packaging Guidelines ---> *SEVERE* issues are present! [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. ---> Cannot find any hint about that in upstream's bugtracker >.> [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in fuzzynet- devel ---> -devel-pkg is obsolete and NOT useful. [?]: Package functions as described. [?]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: fuzzynet-1.2.0-1.fc22.x86_64.rpm fuzzynet-devel-1.2.0-1.fc22.x86_64.rpm fuzzynet-1.2.0-1.fc22.src.rpm fuzzynet.x86_64: E: no-binary fuzzynet.x86_64: W: only-non-binary-in-usr-lib fuzzynet.x86_64: W: no-documentation fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/TipsSample/Properties/Resources.Designer.cs fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/CruiseControlSample/MainForm.Designer.cs fuzzynet-devel.x86_64: W: file-not-utf8 /usr/share/doc/fuzzynet-devel/CruiseControlSample/MainForm.Designer.cs fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/TipsSample/Program.cs fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/CruiseControlSample/Properties/Resources.Designer.cs fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/TipsSample/TipsSample.csproj fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/TipsSample/Properties/Resources.resx fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/TipsSample/Properties/Settings.Designer.cs fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/CruiseControlSample/Properties/AssemblyInfo.cs fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/TipsSample/Properties/Settings.settings fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/CruiseControlSample/MainForm.cs fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/TipsSample/MainForm.resx fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/CruiseControlSample/MainForm.resx fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/CruiseControlSample/CruiseControlSample.csproj fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/TipsSample/MainForm.cs fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/TipsSample/MainForm.Designer.cs fuzzynet-devel.x86_64: W: file-not-utf8 /usr/share/doc/fuzzynet-devel/TipsSample/MainForm.Designer.cs fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/CruiseControlSample/Properties/Resources.resx fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/CruiseControlSample/Properties/Settings.settings fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/TipsSample/Properties/AssemblyInfo.cs fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/CruiseControlSample/Properties/Settings.Designer.cs fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/CruiseControlSample/Program.cs fuzzynet.src:2: E: hardcoded-library-path in %{_prefix}/lib/%{name} fuzzynet.src:55: W: macro-in-comment %{buildroot} fuzzynet.src:55: W: macro-in-comment %{_defaultdocdir} fuzzynet.src:64: W: macro-in-comment %{name} fuzzynet.src:64: W: macro-in-comment %{name} fuzzynet.src: W: invalid-url Source1: http://sf.net/projects/fuzzynet/files/fuzzynet/fuzzynet%20v1.2.0%20%28beta%29/fuzzynet_1.2.0.chm#/fuzzynet.chm HTTP Error 404: Not Found fuzzynet.src: W: invalid-url Source0: http://sf.net/projects/fuzzynet/files/fuzzynet/fuzzynet%20v1.2.0%20%28beta%29/fuzzynet_1.2.0.zip#/fuzzynet-1.2.0.zip HTTP Error 404: Not Found 3 packages and 0 specfiles checked; 2 errors, 30 warnings. Rpmlint (installed packages) ---------------------------- ]0;<mock-chroot><mock-chroot>[root@x220 /]# rpmlint fuzzynet-devel fuzzynet fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/TipsSample/Properties/Resources.Designer.cs fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/CruiseControlSample/MainForm.Designer.cs fuzzynet-devel.x86_64: W: file-not-utf8 /usr/share/doc/fuzzynet-devel/CruiseControlSample/MainForm.Designer.cs fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/TipsSample/Program.cs fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/CruiseControlSample/Properties/Resources.Designer.cs fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/TipsSample/TipsSample.csproj fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/TipsSample/Properties/Resources.resx fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/TipsSample/Properties/Settings.Designer.cs fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/CruiseControlSample/Properties/AssemblyInfo.cs fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/TipsSample/Properties/Settings.settings fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/CruiseControlSample/MainForm.cs fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/TipsSample/MainForm.resx fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/CruiseControlSample/MainForm.resx fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/CruiseControlSample/CruiseControlSample.csproj fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/TipsSample/MainForm.cs fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/TipsSample/MainForm.Designer.cs fuzzynet-devel.x86_64: W: file-not-utf8 /usr/share/doc/fuzzynet-devel/TipsSample/MainForm.Designer.cs fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/CruiseControlSample/Properties/Resources.resx fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/CruiseControlSample/Properties/Settings.settings fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/TipsSample/Properties/AssemblyInfo.cs fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/CruiseControlSample/Properties/Settings.Designer.cs fuzzynet-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/fuzzynet-devel/CruiseControlSample/Program.cs fuzzynet.x86_64: E: no-binary fuzzynet.x86_64: W: only-non-binary-in-usr-lib fuzzynet.x86_64: W: no-documentation 2 packages and 0 specfiles checked; 1 errors, 24 warnings. ]0;<mock-chroot><mock-chroot>[root@x220 /]# echo 'rpmlint-done:' ---> Fix those wrong eol-encodings, not-utf8 and macro-in-comment messages Requires -------- fuzzynet-devel (rpmlib, GLIBC filtered): fuzzynet pkgconfig fuzzynet (rpmlib, GLIBC filtered): mono(mscorlib) Provides -------- fuzzynet-devel: fuzzynet-devel fuzzynet-devel(x86-64) fuzzynet: fuzzynet fuzzynet(x86-64) mono(FuzzyLogicLibrary) Source checksums ---------------- http://sf.net/projects/fuzzynet/files/fuzzynet/fuzzynet v1.2.0 (beta)/fuzzynet_1_2_0.zip#/fuzzynet-1.2.0.zip : CHECKSUM(SHA256) this package : a9cf6019dc8f9d1db63b20d9b1eafaf11ab501008f747b46edf0fa93294681bf CHECKSUM(SHA256) upstream package : a9cf6019dc8f9d1db63b20d9b1eafaf11ab501008f747b46edf0fa93294681bf http://sf.net/projects/fuzzynet/files/fuzzynet/fuzzynet v1.2.0 (beta)/fuzzynet_1_2_0.chm#/fuzzynet.chm : CHECKSUM(SHA256) this package : be04098140f0ad5c36167cfd7107f80b06319c83a42f4a70b76d2060ec775e44 CHECKSUM(SHA256) upstream package : be04098140f0ad5c36167cfd7107f80b06319c83a42f4a70b76d2060ec775e44 Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1166916 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG ===== Further remarks ===== * What does this sh*t do? rm -rf %{source} unzip -q %{SOURCE0} -d %{source} %setup -DTn%{source} Using `%setup -qc` solves your problem… * %SOURCE1 is not versioned… Make this versioned and use `cp -a %{SOURCE1} %{name}.chm` * Using pushd / popd is preferred over using cd * Using mkdir -p ist preferred over install -d because you can create several dirs with one invocation. * You can shorten the SourceX-Urls with using %{url} for the common portion. * URL *never* ends on a slash '/'. ===== Solution ===== **NOT** approved, fix those severe stuff and I'll have another run. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review