[Bug 1013836] Review Request: scorep - Scalable Performance Measurement Infrastructure for Parallel Codes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1013836



--- Comment #22 from Mukundan Ragavan <nonamedotc@xxxxxxxxx> ---
(In reply to Orion Poplawski from comment #21)
> - I don't want to use %license.  It's mainly target at cloud packages (which
> this is not) and complicates the spec for EPEL6 (which I want).

Well, I am confused here. The FPC ticket may have been for cloud, sure, but the
"mother" ticket was far more generic.

As for EPEL6 would it not be possible to add a %if flag?

At some point, you will probably change the spec anyway, no?

Just to be clear, I do not see this as a blocker - just seeking explanation.


> 
> [x]: Package must own all directories that it creates.
>      Note: Directories without known owners: /usr/include/openmpi-x86_64,
>      /usr/include/mpich-x86_64, /usr/share/doc/scorep
> 
> ---> Please fix this.
> 
> # rpm -qf /usr/include/openmpi-x86_64 /usr/include/mpich-x86_64
> /usr/share/doc/scorep | sort -u
> mpich-devel-3.0.4-4.fc20.x86_64
> openmpi-devel-1.7.3-1.fc20.x86_64
> scorep-1.3-1.fc20.x86_64
> 
> so we should be good.

I suppose so.

> 
> -----
>  
> [?]: Fully versioned dependency in subpackages if applicable.
>      Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in scorep-doc
>      , scorep-libs , scorep-mpich , scorep-mpich-libs , scorep-openmpi ,
>      scorep-openmpi-libs
> 
> ---> I think this is fine but I think this should be reviewed to be sure.
> 
> - I want people to be able to install docs separately.
> - scorep-libs is specifically designed for just runtime use
> - the mpi packages are independent of the serial packages
> 

No issues here.

> -----
> 
> scorep.x86_64: E: rpath-in-buildconfig /usr/bin/scorep-config lines ['209']
> scorep-mpich.x86_64: E: rpath-in-buildconfig
> /usr/lib64/mpich/bin/scorep-config lines ['204']
> 
> ---> I do not know how to solve this specific error (yet).
> 
> This is matching the string "rpath" in this files.  Might be nice to get rid
> of, but really useful in general for the project.
> 

I have no problems with this either.

> ----
> 
> shared-lib-calls-exit - I probably have brought this up with upstream, but
> would have to search for it.
> 

Actually, you have already talked about this in comment #5. "Okaying" this as
well.

> -----
> 
> scorep-mpich-libs.x86_64: E: library-without-ldconfig-postin
> /usr/lib64/mpich/lib/libscorep_adapter_pomp_user_event.so.2.0.0
> 
> cannot run ldconfig for the mpi packages - the libraries are not in the ld
> path.
> 

Looking at it again, I misread this. Sorry. This is fine.

> ----
> 
> scorep-mpich-libs.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/mpich/lib/libscorep_online_access_mpi_mockup.so.0.0.0
> /lib64/libpthread.so.0
> 
> I brought these up with upstream, but they felt it would be too much work to
> fix.  I'm inclined to agree, although I do try to reduce overlinkage when I
> can.


Alright. This would not be a terrible problem I suppose.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]