https://bugzilla.redhat.com/show_bug.cgi?id=1173773 --- Comment #8 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- Quick notes: I understand why you were confused by PSR-4: you forget the <vendor> part in the installation tree ;) %global php_vendor bantu %global php_namespace %{php_vendor}/IniGetWrapper mkdir -p %{buildroot}%{_datadir}/php/%{php_namespace} cp -pr src/* %{buildroot}%{_datadir}/php/%{php_namespace} %files ... %{_datadir}/php/%{php_vendor} >From PHP Guidelines => https://fedoraproject.org/wiki/Packaging:PHP#Composer_registered_Packages "Packages must not require any php-pear(foo), but should use php-composer(pear/foo). " This is designed to be able to follow pear requirement, and when pear will totally disappear. So -BuildRequires: php-pear(pear.phpunit.de/PHPUnit) +BuildRequires: php-phpunit-PHPUnit or +BuildRequires: %{_bindir}/phpunit (php-composer(phpunit/phpunit) is not yet provided in all branches, and the library is not really required, so I think BR the command is the better) >From FPC approved Guidelines, even if I think Wiki have never been updated... :( => https://fedorahosted.org/fpc/ticket/411 %{!?_licensedir:%global license %%doc} %license LICENSE >From https://fedoraproject.org/wiki/Packaging:SourceURL#Github Source0 should use "commit" (4770c7feab370c62e23db4f31c112b7c6d90aee2) not the tag (v1.0.1) Please use %{?dist} instead of %{dist}, at least, to make fedora-review happy ;) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review