[Bug 1127636] Review Request: scidavis - Application for Scientific Data Analysis and Visualization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1127636



--- Comment #3 from Dmitrij S. Kryzhevich <krege@xxxxxxx> ---
Hi! Thanks for packaging it.

Some issues.

Looks like you'v fogotten to add postin and postun scripts:
1) gtk-update-icon-cache (you have icons)
2) desktop-file-validate (you have .desktop file)
3) update-desktop-database (you have mine description)

Plugins have .so symlinks that used mainly for developing others applications.
Do you realy need them? I see two possibilities:
1) Scidavis require plugins to be unversioned .so files (as it usualy does).
That require fixing build script.
2) Scidavis require versioniesed plugins and .so files are not required. If you
think they could be used for some other applications they could be putted into
-devel subpackage.

There is no direct link to scidavis sources. One still could get it mannually
but realy have to?

Some files have GPLv3+ license, you should update License tag to "GPLv2+ and
GPLv3+".

/etc/scidavisrc.py was copiled and files "scidavisrc.pyc" "scidavisrc.pyo" were
placed with original .py one. If it is realy config it shoud not to be compiled
and should be marked as config in spec.

Those issues rather small, I believ scidavis would be in repo soon.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]