[Bug 1171553] Review Request: csvdiff - Generate a diff between two CSV files on the command-line

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1171553



--- Comment #2 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
The next Fedora version will probably ship Python 3 as default, and csvdiff
should build with that (at least setup.py says so). Would be nice to also build
the Python 3 version, or only that one.

However, here's the current rpmlint output:

$ rpmlint -i -v *
csvdiff.noarch: I: checking
csvdiff.noarch: I: checking-url https://github.com/larsyencken/csvdiff (timeout
10 seconds)
csvdiff.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/csvdiff/__init__.py 0644L /usr/bin/env
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

csvdiff.noarch: W: no-manual-page-for-binary csvdiff
Each executable in standard binary directories should have a man page.

csvdiff.src: I: checking
csvdiff.src: I: checking-url https://github.com/larsyencken/csvdiff (timeout 10
seconds)
csvdiff.src: E: invalid-spec-name
Your spec filename must end with '.spec'. If it's not the case, rename your
file and rebuild your package.

csvdiff.src: I: checking-url
https://pypi.python.org/packages/source/c/csvdiff/csvdiff-0.1.0.tar.gz (timeout
10 seconds)
csvdiff.spec: I: checking
csvdiff.spec: I: checking-url
https://pypi.python.org/packages/source/c/csvdiff/csvdiff-0.1.0.tar.gz (timeout
10 seconds)
2 packages and 1 specfiles checked; 2 errors, 1 warnings.


Please remove the shebang from
/usr/lib/python2.7/site-packages/csvdiff/__init__.py, scripts in
%{pythonx_sitelib} don't need a shebang at all.

The wrong invalid-spec-name error is bogus, the file is named csvdiff.spec as
usual.

The missing manual page is not up to you to add, but you might contact the
upstream maintainer to add one. I've taken some stuff from the Github site and
wrote a man page, see the attachment.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]