https://bugzilla.redhat.com/show_bug.cgi?id=1128393 --- Comment #6 from Sandro Mani <manisandro@xxxxxxxxx> --- Spec URL: https://smani.fedorapeople.org/review/qhexedit2.spec SRPM URL: https://smani.fedorapeople.org/review/qhexedit2-0.6.3-2.20141212svnr41.fc22.src.rpm %changelog * Fri Dec 12 2014 Sandro Mani <manisandro@xxxxxxxxx> - 0.6.3-2.20141212svnr41 - Update source file name to include svn revision - Fix license LGPLv2+ -> LGPLv2 - Added -Wl,--as-needed to fix unused-direct-shlib-dependency > 0.) You seem to be packaging a SCM snapshot > Please follow the release tag guidelines: http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages Done > 1.) Please pinpoint the source file to a particular SVN revision > Use -r option with svn in your source comment. Done > 2.) Why is the license tag LGPLv2+? Right, the + should not be there... > A LGPLv2 license text is shipped, but it's unclear what it applies to. Upstream needs to clarify that license applies (preferrably in source code), whether it's LGPLv2 or LGPLv2+. I think using LGPLv2 is the correct thing to do. > 3.) Please remove copy of jquery from documentation package According to http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries: Temporary exception for anything to bundle jquery. -> Added Provides: bundled(jquery) to -doc > 4.) Please add license text to main package > Not just the -doc subpackage. The main package gets it via dependency on -libs. > Also you may consider making the -doc subpackage noarch. Uhm, already is?:) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review