[Bug 1128393] Review Request: qhexedit2 - Binary Editor for Qt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1128393



--- Comment #4 from Lubomir Rintel <lkundrak@xxxxx> ---
This seems rather nicely packaged.

* Named correctly
- Not sure about version/release & the upstream source (see below)
- Not sure about the license tag (see below)
- License file not shipped in main package (see below)
* SPEC file clean and legible
* Builds fine in mock
- Documentation bundles jquery (see below)
* Filelist sane
* Dependencies sane

0.) You seem to be packaging a SCM snapshot

Please follow the release tag guidelines:
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages

1.) Please pinpoint the source file to a particular SVN revision

Use -r option with svn in your source comment.

2.) Why is the license tag LGPLv2+?

A LGPLv2 license text is shipped, but it's unclear what it applies to. Upstream
needs to clarify that license applies (preferrably in source code), whether
it's LGPLv2 or LGPLv2+.

3.) Please remove copy of jquery from documentation package

Use packaged version if needed.

4.) Please add license text to main package

Not just the -doc subpackage.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]