[Bug 1157213] Review Request: brutalchess - Impressive 3D chess game

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1157213



--- Comment #4 from Rex Dieter <rdieter@xxxxxxxxxxxx> ---
naming: NOT ok

1.  MUST fix, pkg Summary doesn't match bugzilla Summary
Summary: Impressive 3D chess game
vs
Summary: Chess game with full 3D graphics

I'd suggest simpler:
Summary: Chess game with 3D graphics
(I don't think including "full" there adds value)


licensing: ok


sources: ok, verified content to be identical to upstream + run through pruning
script.


macros: NOT ok
2.  MUST fix commented macros
#%global buildtex  0
doesn't work as you expect, macros in comments are still evaluated (yes wierd,
but that's how rpm works).  Better:
#global buildtex  0


scriptlets: n/a

dir/file ownership: NOT ok, 
3. package MUST own %{_datadir}/%{name} dir
you can either add
%dir %{_datadir}/%{name}/
or replace all of:
%{_datadir}/%{name}/art/
%{_datadir}/%{name}/models/
%{_datadir}/%{name}/fonts/
with just:
%{_datadir}/%{name}/


Please fix items 1-3, and things are looking good.


additional comments:
* I can help fix tex/font issues post-review, it's just a matter of missing
BuildRequires

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]