[Bug 1142407] Review Request: drpm - deltarpm manipulation library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1142407

Michael Schwendt <bugs.michael@xxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(bugs.michael@gmx. |
                   |net)                        |



--- Comment #17 from Michael Schwendt <bugs.michael@xxxxxxx> ---
Just the .so symlink is missing now in the -devel package. One cannot link with
-ldrpm without this symlink. 

The %changelog tells:

  | - Removed unversioned .so from package

That only tells what has been done, not _why_ it has been done. ;-) The better
comments in changelogs and in source code give the rationale and answer the
"why?".

And yes, the upstream drpm Makefile ought to install this symlink to begin
with.


> %install
> make install DESTDIR=%{buildroot} ...

The guidelines recommend %make_install these days (see "rpm -E %make_install"
for what it does).

  %make_install libdir=%{_libdir} includedir=%{_includedir}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]