[Bug 1171302] Review Request: nodejs-sentence-case - Sentence case a string

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1171302

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ Package built successful in mock (f22 x86_64)

+ rpmlint on generated rpms gave output
nodejs-sentence-case.noarch: W: spelling-error %description -l en_US toString
-> to String, to-string, stringing
nodejs-sentence-case.noarch: W: spelling-error %description -l en_US booleans
-> boo leans, boo-leans, Boolean
nodejs-sentence-case.noarch: W: only-non-binary-in-usr-lib
nodejs-sentence-case.src: W: spelling-error %description -l en_US toString ->
to String, to-string, stringing
nodejs-sentence-case.src: W: spelling-error %description -l en_US booleans ->
boo leans, boo-leans, Boolean
2 packages and 0 specfiles checked; 0 errors, 5 warnings.


+ Source verified with upstream as (sha256sum)
srpm tarball: f7c7f59d23e23ce403f5b17b42c5a849a44ce56390887bdfdeb7547ab8000a6d
upstream tarball: 
f7c7f59d23e23ce403f5b17b42c5a849a44ce56390887bdfdeb7547ab8000a6d

+ License is "MIT" and included in its own LICENSE file.

+ follows nodejs packaging guidelines.

Suggestions:
1) Remove Group tag

1) To run tests you should
BuildRequires:  npm(mocha)
BuildRequires:  npm(chai)


APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]