Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pear-File-SMBPasswd - Class for managing SAMBA style password files Alias: pear-File-SMBPasswd https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=232171 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Flag| |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-05-06 14:11 EST ------- As usual, builds cleanly and rpmlint is silent. * source files match upstream: 93b1c58ea0576629c97a6eb6ab45b474191957866503760432721ea21dd7296d File_SMBPasswd-1.0.2.tgz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: php-pear(File_SMBPasswd) = 1.0.2 php-pear-File-SMBPasswd = 1.0.2-1.fc7 = /bin/sh /usr/bin/pear php-pear(Crypt_CHAP) >= 1.0.0 php-pear(PEAR) * %check is not present; no test suite upstream. * owns the directories it creates. * doesn't own any directories it shouldn't. /usr/share/pear/File is also owned by php-pear-File, but it's not a dependency and doesn't need to be. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review