[Bug 1171263] Review Request: nodejs-istanbul - A JS code coverage tool written in JS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1171263



--- Comment #8 from Piotr Popieluch <piotr1212@xxxxxxxxx> ---
Thank you. I was actually looking into it right now, you beat me ;)

updated spec and srpm:
Spec URL: https://piotrp.fedorapeople.org/nodejs-istanbul.spec
SRPM URL: https://piotrp.fedorapeople.org/nodejs-istanbul-0.3.2-3.fc21.src.rpm


- Renamed binary name to prevent conflict
- Temporary disabled tests because of RHBZ#1172471
- Removed group tag
- Added rm -rf node_modules


Only actually using istanbul gives me the same error as the test because of
missing dist dir:


➜  rpmbuild  /usr/bin/istanbul-js 
Cannot find module '../dist/cjs/handlebars'
Error: Cannot find module '../dist/cjs/handlebars'
    at Function.Module._resolveFilename (module.js:338:15)
    at Function.Module._load (module.js:280:25)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> (/usr/lib/node_modules/handlebars/index.js:6:18)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)

Error: Could not register report from file html.js
    at /usr/lib/node_modules/istanbul/lib/util/factory.js:60:27
    at Array.forEach (native)
    at Object.Factory.loadStandard
(/usr/lib/node_modules/istanbul/lib/util/factory.js:53:29)
    at Object.<anonymous>
(/usr/lib/node_modules/istanbul/lib/register-plugins.js:11:8)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)



Should we wait on https://bugzilla.redhat.com/show_bug.cgi?id=1172471 before
approving?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]